[Backport release-24.11] zulip: build package from source#362394
[Backport release-24.11] zulip: build package from source#362394JohnRTitor merged 2 commits intoNixOS:release-24.11from
Conversation
github-actions
bot
added
10.rebuild-darwin: 0
|
@ofborg build zulip |
There was a problem hiding this comment.
I forgot to mention this on the other PR, but this can likely build on aarch64-linux as well. Could you try changing the meta.platforms and check if it builds on aarch64-linux? @nbdd0121
|
It builds fine, although probably that change should be a separate PR to master and then backported? |
|
Yes, that's what I was asking for. Let's hold off on merging this one, just open another PR targeting master with the meta.platforms change. After that gets merged, cherry-pick the commit here. |
JohnRTitor
left a comment
JohnRTitor
left a comment
There was a problem hiding this comment.
Cherry-picks should be done with the -x flag.
There was a problem hiding this comment.
Please cherry-pick 2160e7d instead, it is recommended to cherry-pick exactly the same changes, else issues may arise during future auto backports. I would suggest you leave the wayland-ime and env change as it is.
ofborg
bot
added
the
10.rebuild-linux: 1
Currently this uses AppImage which comes with its own electron and then we run it under FHS. This is not ideal since: * it suffers from "too many electrons" issue * we are relying upstream to bump electron version for bugfixes Signed-off-by: John Titor <50095635+JohnRTitor@users.noreply.github.com> (cherry picked from commit 2160e7d)
(cherry picked from commit 29d7565)
github-actions
bot
removed
the
10.rebuild-linux: 1
ofborg
bot
added
the
10.rebuild-linux: 1
3 participants
This is the manual backport of #279545, automatic backport of which failed due to #358620.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.